Add support for customizing image and extension chart repoURL across templates #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squizzi
force-pushed
the
airgap-template-changes
branch
3 times, most recently
from
c7480ab to
afcb387
Compare
a13x5
requested changes
Oct 23, 2024
templates/cluster/aws-standalone-cp/templates/k0scontrolplane.yaml
Outdated
Show resolved
Hide resolved
templates/cluster/aws-hosted-cp/templates/k0smotroncontrolplane.yaml
Outdated
Show resolved
Hide resolved
templates/cluster/azure-hosted-cp/templates/k0smotroncontrolplane.yaml
Outdated
Show resolved
Hide resolved
templates/cluster/azure-hosted-cp/templates/k0smotroncontrolplane.yaml
Outdated
Show resolved
Hide resolved
templates/cluster/azure-standalone-cp/templates/k0scontrolplane.yaml
Outdated
Show resolved
Hide resolved
templates/cluster/vsphere-standalone-cp/templates/k0scontrolplane.yaml
Outdated
Show resolved
Hide resolved
squizzi
force-pushed
the
airgap-template-changes
branch
from
afcb387 to
76dc00e
Compare
squizzi
force-pushed
the
airgap-template-changes
branch
from
76dc00e to
80086e5
Compare
squizzi
force-pushed
the
airgap-template-changes
branch
3 times, most recently
from
4d44f9e to
b8f8cb3
Compare
a13x5
requested changes
Nov 6, 2024
squizzi
force-pushed
the
airgap-template-changes
branch
from
b8f8cb3 to
01ed0f4
Compare
squizzi
force-pushed
the
airgap-template-changes
branch
from
01ed0f4 to
f37636c
Compare
In order to support airgap, users will need to be able to specify custom extensions.imageRepository values and extensions.chartRepository URLs to be able to download extension images and charts on 'ManagedClusters'. These additions across the helm templates allow them to do so. Signed-off-by: Kyle Squizzato <[email protected]>
Signed-off-by: Kyle Squizzato <[email protected]>
Signed-off-by: Kyle Squizzato <[email protected]>
a13x5
force-pushed
the
airgap-template-changes
branch
from
f37636c to
355dd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #425