Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile MultiClusterService #476

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Reconcile MultiClusterService #476

merged 1 commit into from
Oct 18, 2024

Conversation

wahabmk
Copy link
Contributor

@wahabmk wahabmk commented Oct 11, 2024 •
edited
Loading

Description

  1. Implemented Reconcile for MultiClusterService.
  2. Does not implement status. That will be done in Implement Status for MultiClusterService #460.
  3. Some refactoring.

Sanity Testing

The following demo shows some sanity testing:

multiclusterservice-720p.mov

@wahabmk wahabmk self-assigned this Oct 11, 2024
@wahabmk wahabmk linked an issue Oct 11, 2024 that may be closed by this pull request
Implement Reconciliation for MultiClusterService #455
Closed
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch 12 times, most recently from c3cfc6b to 0739289 Compare October 11, 2024 13:43
@wahabmk wahabmk marked this pull request as ready for review October 11, 2024 13:47
zerospiel
zerospiel reviewed Oct 11, 2024
View reviewed changes
api/v1alpha1/managedcluster_types.go Show resolved Hide resolved
internal/controller/multiclusterservice_controller.go Outdated Show resolved Hide resolved
internal/controller/multiclusterservice_controller.go Outdated Show resolved Hide resolved
internal/controller/multiclusterservice_controller.go Outdated Show resolved Hide resolved
internal/sveltos/profile.go Outdated Show resolved Hide resolved
internal/sveltos/profile.go Show resolved Hide resolved
internal/sveltos/profile.go Show resolved Hide resolved
internal/sveltos/profile.go Show resolved Hide resolved
internal/sveltos/profile.go Outdated Show resolved Hide resolved
internal/sveltos/profile.go Outdated Show resolved Hide resolved
Schnitzel
Schnitzel requested changes Oct 14, 2024
View reviewed changes
api/v1alpha1/managedcluster_types.go Outdated Show resolved Hide resolved
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch 4 times, most recently from 472d821 to f2fb0d4 Compare October 16, 2024 23:47
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch from f2fb0d4 to bebe529 Compare October 17, 2024 03:47
zerospiel
zerospiel reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Regarding the integration tests, it feels like there is room to implement more checks (e.g. the actual statuses of the requested object or dependant objects) but I'd left that idea to think to the author and other reviewers

Schnitzel
Schnitzel previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Schnitzel Schnitzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Schnitzel Schnitzel mentioned this pull request Oct 18, 2024
Closed
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch from bebe529 to 61de7ea Compare October 18, 2024 02:56
@wahabmk
Copy link
Contributor Author

wahabmk commented Oct 18, 2024

LGTM. Regarding the integration tests, it feels like there is room to implement more checks (e.g. the actual statuses of the requested object or dependant objects) but I'd left that idea to think to the author and other reviewers

Further tests to check status can be implemented as part of #460.

eromanova
eromanova previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@eromanova eromanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/sveltos/profile.go Outdated Show resolved Hide resolved
@wahabmk wahabmk dismissed stale reviews from eromanova and Schnitzel via 307357a October 18, 2024 11:49
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch 2 times, most recently from 307357a to 38e489c Compare October 18, 2024 11:50
@wahabmk wahabmk force-pushed the reconcile-multiclusterservice branch from 38e489c to 72c2932 Compare October 18, 2024 12:02
@eromanova eromanova merged commit 22c4462 into Mirantis:main Oct 18, 2024
5 checks passed
bnallapeta pushed a commit to bnallapeta/hmc that referenced this pull request Nov 15, 2024
@wahabmk
Reconcile MultiClusterService (Mirantis#476)
c31265f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mestadler mestadler mestadler left review comments

@zerospiel zerospiel zerospiel left review comments

@eromanova eromanova eromanova approved these changes

@Schnitzel Schnitzel Schnitzel left review comments

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

@squizzi squizzi Awaiting requested review from squizzi

@kylewuolle kylewuolle Awaiting requested review from kylewuolle

@slysunkin slysunkin Awaiting requested review from slysunkin

Assignees

@wahabmk wahabmk

Labels
None yet
Projects
Project 2A
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Reconciliation for MultiClusterService
5 participants
@wahabmk @Schnitzel @zerospiel @mestadler @eromanova