-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Templates deletion validation #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
September 23, 2024 10:31
176cb64
to
f27b9ce
Compare
eromanova
force-pushed
the
template-validation
branch
4 times, most recently
from
September 26, 2024 13:45
8fa5584
to
5d46cee
Compare
Kshatrix
requested changes
Sep 27, 2024
eromanova
force-pushed
the
template-validation
branch
from
October 16, 2024 16:35
5d46cee
to
f01b819
Compare
eromanova
force-pushed
the
template-validation
branch
from
October 18, 2024 12:10
f01b819
to
fb3d9e0
Compare
eromanova
changed the title
Allow Templates deletion by the controller only
Improve Templates deletion validation
Oct 18, 2024
eromanova
force-pushed
the
template-validation
branch
from
October 21, 2024 09:34
fb3d9e0
to
7dbda57
Compare
Kshatrix
requested changes
Oct 21, 2024
eromanova
force-pushed
the
template-validation
branch
from
October 21, 2024 18:54
7dbda57
to
03becc2
Compare
eromanova
force-pushed
the
template-validation
branch
from
October 22, 2024 12:27
03becc2
to
83d4900
Compare
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
October 25, 2024 11:16
ee7c734
to
995c17f
Compare
eromanova
force-pushed
the
template-validation
branch
from
October 28, 2024 09:26
995c17f
to
d24f391
Compare
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
November 11, 2024 09:42
aa3e359
to
5c08a8c
Compare
eromanova
force-pushed
the
template-validation
branch
from
November 12, 2024 08:54
5c08a8c
to
220b985
Compare
eromanova
force-pushed
the
template-validation
branch
from
November 13, 2024 10:28
220b985
to
30564da
Compare
eromanova
force-pushed
the
template-validation
branch
from
November 21, 2024 12:23
30564da
to
dca242a
Compare
eromanova
commented
Nov 21, 2024
eromanova
requested review from
Kshatrix
and removed request for
squizzi and
Kshatrix
November 25, 2024 11:03
eromanova
force-pushed
the
template-validation
branch
3 times, most recently
from
December 3, 2024 11:09
d967b7d
to
d2c3317
Compare
Kshatrix
requested changes
Dec 3, 2024
eromanova
force-pushed
the
template-validation
branch
from
December 3, 2024 17:05
d2c3317
to
de21f26
Compare
eromanova
force-pushed
the
template-validation
branch
from
December 4, 2024 08:35
de21f26
to
ea50696
Compare
eromanova
force-pushed
the
template-validation
branch
from
December 4, 2024 12:49
ea50696
to
74cc3ef
Compare
zerospiel
previously approved these changes
Dec 4, 2024
eromanova
force-pushed
the
template-validation
branch
from
December 6, 2024 09:42
74cc3ef
to
abf3e0c
Compare
Kshatrix
requested changes
Dec 6, 2024
The following rules are validated: 1. ClusterTemplate or ServiceTemplate can't be removed if it is in use by ManagedCluster or owned by TemplateChain 2. ProviderTemplate can't be removed if it's a core provider or enabled in Management spec.providers
eromanova
force-pushed
the
template-validation
branch
from
December 6, 2024 10:37
abf3e0c
to
5bc172d
Compare
Kshatrix
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following template deletion rules are validated:
ClusterTemplate
orServiceTemplate
can't be removed if it is in use byManagedCluster
or owned byTemplateChain
ProviderTemplate
can't be removed if it's a core provider or enabled in Managementspec.providers
Closes #329