Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ManagedCluster validation #257

Closed
wants to merge 1 commit into from

Conversation

eromanova
Copy link
Member

@eromanova eromanova commented Sep 4, 2024

Closes #236 #249

This PR introduces the following changes:

  1. Verify core components' and required providers' readiness on ManagedCluster creation according to the Management object status
  2. Adapt testing cases accordingly

@eromanova eromanova requested a review from Kshatrix September 4, 2024 12:03
@eromanova eromanova self-assigned this Sep 4, 2024
@eromanova eromanova force-pushed the deployment-validation branch from 6bf29d7 to 27da783 Compare September 5, 2024 10:22
@eromanova eromanova changed the title Improve Deployment validation Improve ManagedCluster validation Sep 5, 2024
@eromanova eromanova force-pushed the deployment-validation branch from 27da783 to 8f2caaa Compare September 10, 2024 13:21
@squizzi
Copy link

squizzi commented Sep 10, 2024

This looks like it will also address #249

@Kshatrix
Copy link
Collaborator

We have some updates to the Management CR planned. Let's get back to this issue after we land them.

@eromanova
Copy link
Member Author

Closing as redundant

@eromanova eromanova closed this Oct 16, 2024
@eromanova eromanova deleted the deployment-validation branch October 16, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Admission] Verify requested providers readiness before admitting Deployment creation
3 participants