Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admission] Improve ManagedCluster validation #244

Closed
eromanova opened this issue Sep 3, 2024 · 0 comments · Fixed by #527
Closed

[Admission] Improve ManagedCluster validation #244

eromanova opened this issue Sep 3, 2024 · 0 comments · Fixed by #527
Assignees
@eromanova

Comments

@eromanova
Copy link
Member

eromanova commented Sep 3, 2024 •
edited
Loading

We should check the referenced template validity on ManagedCluster Update only if the template was changed in ManagedCluster's spec (compare the old spec.template with the new spec.template value).

Currently, the admission webhook will block any update to the ManagedCluster object if the referenced template became invalid for some reason. But we should still allow changing other fields except for the spec.template (e.g. spec.config).
@eromanova eromanova self-assigned this Sep 4, 2024
@eromanova eromanova moved this to In Progress in Project 2A Sep 4, 2024
eromanova added a commit to eromanova/hmc that referenced this issue Sep 4, 2024
@eromanova
Check Deployment template valideness only in case it was changed
9e1c6d8 
Closes Mirantis#244
eromanova added a commit to eromanova/hmc that referenced this issue Sep 4, 2024
@eromanova
Check Deployment template validness only in case it was changed
6bf29d7 
Closes Mirantis#244
@eromanova eromanova mentioned this issue Sep 4, 2024
Closed
eromanova added a commit to eromanova/hmc that referenced this issue Sep 5, 2024
@eromanova
Check ManagedCluster template validness only in case it was changed
27da783 
Closes Mirantis#244
eromanova added a commit to eromanova/hmc that referenced this issue Sep 10, 2024
@eromanova
Check ManagedCluster template validness only in case it was changed
8f2caaa 
Closes Mirantis#244
eromanova added a commit to eromanova/hmc that referenced this issue Sep 12, 2024
@eromanova
Check ManagedCluster template validness only in case it was changed
ae93c3c 
Closes Mirantis#244
@eromanova eromanova mentioned this issue Sep 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Project 2A Oct 16, 2024
@eromanova eromanova reopened this Oct 16, 2024
@eromanova eromanova moved this from Done to In Progress in Project 2A Oct 16, 2024
@eromanova eromanova changed the title [Admission] Improve Deployment validation [Admission] Improve ManagedCluster validation Oct 18, 2024
eromanova added a commit to eromanova/hmc that referenced this issue Oct 18, 2024
@eromanova
Improve ManagedCluster update validation
467dc7b 
Validate template only in case it was updated in the cluster's spec

Closes Mirantis#244
@eromanova eromanova mentioned this issue Oct 18, 2024
Merged
eromanova added a commit to eromanova/hmc that referenced this issue Oct 18, 2024
@eromanova
Improve ManagedCluster update validation
22afeb5 
Validate template only in case it was updated in the cluster's spec

Closes Mirantis#244
@github-project-automation github-project-automation bot moved this from In Progress to Done in Project 2A Oct 18, 2024
bnallapeta pushed a commit to bnallapeta/hmc that referenced this issue Nov 15, 2024
@eromanova @Kshatrix
Improve ManagedCluster update validation
9618537 
Validate template only in case it was updated in the cluster's spec

Closes Mirantis#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eromanova eromanova

Labels
None yet
Projects
Project 2A
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve ManagedCluster update validation eromanova/hmc
1 participant
@eromanova