Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fallback to process definition key if process name is missing #476

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

lmoesle
Copy link
Member

@lmoesle lmoesle commented Sep 18, 2024

closes #475

@github-actions github-actions bot added the bug Something isn't working label Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.94%. Comparing base (191543f) to head (047e394).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #476      +/-   ##
============================================
+ Coverage     58.85%   58.94%   +0.08%     
- Complexity      205      207       +2     
============================================
  Files           139      139              
  Lines          1383     1386       +3     
  Branches         99      101       +2     
============================================
+ Hits            814      817       +3     
  Misses          537      537              
  Partials         32       32              
Flag Coverage Δ
unittests 58.94% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmoesle lmoesle requested a review from DaAnda97 September 18, 2024 08:32
@lmoesle
Copy link
Member Author

lmoesle commented Sep 18, 2024

@DaAnda97 I quickly fixed the bug you discovered yesterday. Instead of throwing an error if a process doesn't have a name, I will show a warning and use the processDefinitionKey instead.

Copy link
Member

@DaAnda97 DaAnda97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@lmoesle lmoesle merged commit 36860ed into main Sep 18, 2024
6 checks passed
@lmoesle lmoesle deleted the bugfix/throw-exception-if-process-has-no-name branch September 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint Violation Exception is thrown if process name is not configured in bpmn
3 participants