bugfix: fix get task by id typo (#427)

Fixing a small typo causing the get task by id endpoint to fail.
Miragon · Jul 23, 2024 · 0c45235 · 0c45235
1 parent 1216594
commit 0c45235
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...src/main/java/io/miragon/miranum/platform/tasklist/application/port/in/UserTaskQuery.java b/...src/main/java/io/miragon/miranum/platform/tasklist/application/port/in/UserTaskQuery.java
@@ -11,5 +11,5 @@ public interface UserTaskQuery {
 
     List<Task> getTasksForUser(final String user);
 
-    Task getTask(final String user, final String taskId);
+    Task getTask(final String taskId, final String user);
 }
diff --git a/...main/java/io/miragon/miranum/platform/tasklist/application/service/UserTaskQueryImpl.java b/...main/java/io/miragon/miranum/platform/tasklist/application/service/UserTaskQueryImpl.java
@@ -28,7 +28,7 @@ public List<Task> getTasksForUser(final String user) {
     }
 
     @Override
-    public Task getTask(final String user, final String taskId) throws TaskAccessDeniedException {
+    public Task getTask(final String taskId, final String user) throws TaskAccessDeniedException {
         final Task task = this.taskOutPort.getTask(taskId);
         return userTaskAccessProvider.hasAccess(task, user);
     }

diff --git a/.../java/io/miragon/miranum/platform/tasklist/application/service/UserTaskQueryImplTest.java b/.../java/io/miragon/miranum/platform/tasklist/application/service/UserTaskQueryImplTest.java
@@ -114,7 +114,7 @@ void test_get_task_by_id() {
 
         when(taskOutPort.getTask(taskId)).thenReturn(tasks);
 
-        final Task result = userTaskQuery.getTask(user, taskId);
+        final Task result = userTaskQuery.getTask(taskId, user);
 
         assertThat(result)
                 .isNotNull()
@@ -136,7 +136,7 @@ void test_get_task_by_id_with_no_access() {
                 .formKey("exampleForm")
                 .build());
 
-        assertThatThrownBy(() -> userTaskQuery.getTask(user, taskId))
+        assertThatThrownBy(() -> userTaskQuery.getTask(taskId, user))
                 .isInstanceOf(TaskAccessDeniedException.class)
                 .hasMessage("User notAssignedUser has no access to task 5");
     }