Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-editor): plugin for config files #412

Merged
merged 23 commits into from
Nov 8, 2023
Merged

feat(config-editor): plugin for config files #412

merged 23 commits into from
Nov 8, 2023

Conversation

peterhnm
Copy link
Member

@peterhnm peterhnm commented Oct 17, 2023 •
edited
Loading

Issue

Description

Create the first version of the plugin.

Checklist

  • Code is easy to understand
  • No obvious errors or bugs
  • CI/CD Pipelines did run successfully
  • Tests were implemented
  • Documentation was created

@peterhnm peterhnm self-assigned this Oct 17, 2023
@peterhnm peterhnm linked an issue Oct 17, 2023 that may be closed by this pull request
[Feature] Create first version of the plugin #411
Closed
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...s/miranum-config-editor/src/application/portsIn.ts 27.02% <27.02%> (ø)
.../miranum-config-editor/src/application/usecases.ts 32.60% <32.60%> (ø)

📢 Thoughts on this report? Let us know!.

@peterhnm
fix: bug when open an empty file
b1b8848
@peterhnm
Merge branch 'main' into feat/plugin_for_config_files
42bd993 
# Conflicts:
#	apps/miranum-console-webview/project.json
#	apps/miranum-console/project.json
#	apps/miranum-extension-pack/CHANGELOG.md
#	apps/miranum-forms-webview/project.json
#	apps/miranum-forms/project.json
#	apps/miranum-modeler-bpmn-webview/project.json
#	apps/miranum-modeler-dmn-webview/project.json
#	apps/miranum-modeler/project.json
#	libs/miranum-core/project.json
#	libs/miranum-create-append-c7-element-templates/project.json
#	libs/vscode/miranum-vscode-webview/project.json
#	libs/vscode/miranum-vscode/project.json
#	libs/vscode/shared/miranum-console/project.json
#	libs/vscode/shared/miranum-forms/project.json
#	libs/vscode/shared/miranum-modeler/project.json
#	nx.json
#	package-lock.json
#	package.json
@peterhnm
chore: merge main into feat/plugin_for_config_files
922e214
@peterhnm peterhnm merged commit e74e688 into main Nov 8, 2023
2 checks passed
@peterhnm peterhnm deleted the feat/plugin_for_config_files branch November 8, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikhorn93 dominikhorn93 Awaiting requested review from dominikhorn93

Assignees

@peterhnm peterhnm

Labels
miranum-cli NPM release miranum-config-editor miranum-config-editor-webview miranum-console miranum-console-webview miranum-core Library miranum-create-append-c7-element-templates Library miranum-extension-pack miranum-modeler miranum-modeler-bpmn-webview miranum-modeler-dmn-webview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Create first version of the plugin
2 participants
@peterhnm @codecov-commenter