Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Update document about BlockEntry #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Anzide
Copy link

@Anzide Anzide commented Aug 28, 2022

Described that BlockEntry store the vanilla data,and couldn't be modified.
It's my first time to submit a PR as a software enginnering student,so be free to point out my problems.

world/blocks.md Outdated
@@ -26,9 +26,15 @@ Block tnt = Block.TNT.withProperty("unstable", "true");
instance.setBlock(0, 41, 0, tnt);
```

## Registry
## BlockEntry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should stay Registry

world/blocks.md Outdated

`BlockEntry` is unmodifiable by now, though we have the plan to make it modifiable in the future.

`BlockEntry` could be retrieved with `Block#registry()`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be retrieved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: is unmodifiable for now
Might also help: thought we plan to make it modifiable in the future.

@Anzide Anzide requested a review from TheMode August 28, 2022 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants