This repository has been archived by the owner on May 26, 2018. It is now read-only.
Added extra priorities to support Sponge #518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,6 +147,10 @@ public boolean post(Event event) | |||
| return (event.isCancelable() ? event.isCanceled() : false); | |||
| } | |||
|
|
|||
| public int getbusID() { | |||
There was a problem hiding this comment.
"getBusID" - forgot to uppercase the B ;)
Raphfrk
force-pushed
the
extra_priorities
branch
from
af76501
to
a5f229e
Compare
| HIGHEST, //First to execute | ||
| PRE, //First to execute. Cancellation is not allowed | ||
| AFTER_PRE, //Cancellation is not allowed | ||
| HIGHEST, //First standard priority to execute |
There was a problem hiding this comment.
I still dont agree with adding this new things. It gives no extra functionality besides 'I wanna have more!'
There was a problem hiding this comment.
It means we can do a one to one mapping of the priorities.
There was a problem hiding this comment.
I understand that is your intention, however, I've had discussions about this. As i said, Sponge shouldn't be adding more for the sake of having more...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponge has 4 extra priority levels. This expands the EventPriority enum so that the extra priorities are supported.
It also adds a .getBusID() method to the EventBus class. This means that the Sponge event system can directly submit events to the ListenerLists associated with Forge events.