Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

380 sync task registry update ak requirements and measures synchronization #78

Merged
merged 4 commits into from
Dec 9, 2024
Merged

380 sync task registry update ak requirements and measures synchronization #78

merged 4 commits into from
Dec 9, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Dec 3, 2024 •
edited
Loading

Description

  • Add link to github action in the mattermost notify
  • Add Error handling for conversion scripts
  • Catch error handling in sync script and exit when it fails

Resolves https://github.com/orgs/MinBZK/projects/7/views/3?pane=issue&itemId=88087463&issue=MinBZK%7Camt%7C380

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner December 3, 2024 12:08
@laurensWe laurensWe linked an issue Dec 3, 2024 that may be closed by this pull request
Sync task-registry: Update AK requirements and measures synchronization MinBZK/amt#380
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

berrydenhartog
berrydenhartog approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChristopherSpelt
ChristopherSpelt approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ravimeijerrig
ravimeijerrig approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@laurensWe laurensWe merged commit 61a71fe into main Dec 9, 2024
14 of 16 checks passed
@laurensWe laurensWe deleted the 380-sync-task-registry-update-ak-requirements-and-measures-synchronization branch December 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravimeijerrig ravimeijerrig ravimeijerrig approved these changes

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync task-registry: Update AK requirements and measures synchronization
4 participants
@laurensWe @berrydenhartog @ChristopherSpelt @ravimeijerrig