Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

341 create endpoints for maatregelen and vereisten #67

Merged
merged 1 commit into from
Nov 8, 2024
Merged

341 create endpoints for maatregelen and vereisten #67

merged 1 commit into from
Nov 8, 2024

Conversation

ChristopherSpelt
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt commented Oct 31, 2024 •
edited
Loading

Description

Changed existing endpoints
instruments/ and urns/?{urn}
to
instruments/ and instruments/urn/{urn}

Added endpoints:
measures/ and measures/urn/{urn}
requirements/ and requirements/urn/{urn}

Resolves #341

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ChristopherSpelt ChristopherSpelt self-assigned this Oct 31, 2024
@ChristopherSpelt ChristopherSpelt linked an issue Oct 31, 2024 that may be closed by this pull request
Create endpoints for maatregelen and vereisten MinBZK/amt#341
Closed
@ChristopherSpelt ChristopherSpelt force-pushed the 341-create-endpoints-for-maatregelen-and-vereisten branch 4 times, most recently from 0882bca to eac2f6d Compare November 5, 2024 11:15
@ChristopherSpelt ChristopherSpelt marked this pull request as ready for review November 5, 2024 12:35
@ChristopherSpelt ChristopherSpelt requested a review from a team as a code owner November 5, 2024 12:35
@ChristopherSpelt ChristopherSpelt force-pushed the 341-create-endpoints-for-maatregelen-and-vereisten branch 2 times, most recently from c0ea1d8 to e516750 Compare November 5, 2024 14:22
uittenbroekrobbert
uittenbroekrobbert approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, other than that, LGTM!

@ChristopherSpelt ChristopherSpelt force-pushed the 341-create-endpoints-for-maatregelen-and-vereisten branch from e516750 to fc8c9fc Compare November 6, 2024 09:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChristopherSpelt ChristopherSpelt merged commit 9c9c6b3 into main Nov 8, 2024
13 of 15 checks passed
@ChristopherSpelt ChristopherSpelt deleted the 341-create-endpoints-for-maatregelen-and-vereisten branch November 8, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees

@ChristopherSpelt ChristopherSpelt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create endpoints for maatregelen and vereisten
2 participants
@ChristopherSpelt @uittenbroekrobbert