Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the demo suite #95

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix for the demo suite #95

merged 1 commit into from
Jul 13, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

Description

The demo suite ran into referential constraint. This fix solves that problem and creates a stable demo environment.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner July 11, 2024 17:43
@uittenbroekrobbert uittenbroekrobbert force-pushed the feature/update-demo-suite branch from 52258b7 to 8f75f8b Compare July 11, 2024 18:52
@uittenbroekrobbert uittenbroekrobbert force-pushed the feature/update-demo-suite branch from 8f75f8b to 847a43c Compare July 11, 2024 18:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

anneschuth
anneschuth approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would the idea be that we can drop this code after it has been applied?

berrydenhartog
berrydenhartog approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog merged commit 2f543f6 into main Jul 13, 2024
14 of 15 checks passed
@berrydenhartog berrydenhartog deleted the feature/update-demo-suite branch July 13, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

@anneschuth anneschuth anneschuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uittenbroekrobbert @anneschuth @berrydenhartog