Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook to disallow modifying migrations #80

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Add pre-commit hook to disallow modifying migrations #80

merged 1 commit into from
Jul 5, 2024

Conversation

anneschuth
Copy link
Member

Description

Adds pre-commit hook to disallow modifying migrations

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@anneschuth anneschuth self-assigned this Jul 4, 2024
@anneschuth anneschuth force-pushed the feature/disallow-editing-migrations branch from 700b97c to ffe0112 Compare July 5, 2024 07:15
@anneschuth anneschuth requested a review from berrydenhartog July 5, 2024 07:16
berrydenhartog
berrydenhartog approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog enabled auto-merge July 5, 2024 07:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@berrydenhartog berrydenhartog merged commit 7278103 into main Jul 5, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the feature/disallow-editing-migrations branch July 5, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

@ChristopherSpelt ChristopherSpelt Awaiting requested review from ChristopherSpelt

@uittenbroekrobbert uittenbroekrobbert Awaiting requested review from uittenbroekrobbert

Assignees

@anneschuth anneschuth

Labels
None yet
Projects
👾 AI Validation Team Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anneschuth @berrydenhartog