generated from MinBZK/python-project-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup basic project config #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurensWe
reviewed
Apr 30, 2024
laurensWe
reviewed
Apr 30, 2024
laurensWe
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor textual suggestions.
laurensWe
reviewed
May 1, 2024
berrydenhartog
force-pushed
the
setup-project
branch
2 times, most recently
from
May 1, 2024 07:16
b9c049f
to
0988257
Compare
berrydenhartog
force-pushed
the
setup-project
branch
from
May 1, 2024 07:20
0988257
to
bcc40f2
Compare
berrydenhartog
force-pushed
the
setup-project
branch
from
May 1, 2024 07:48
adc5f46
to
dcb1321
Compare
berrydenhartog
force-pushed
the
setup-project
branch
from
May 1, 2024 08:54
6dff31d
to
b2c2334
Compare
berrydenhartog
force-pushed
the
setup-project
branch
from
May 1, 2024 08:56
b2c2334
to
b00651b
Compare
Co-authored-by: Robbert Uittenbroek <[email protected]> Signed-off-by: Berry den Hartog <[email protected]>
Very nice! I made some minor remarks, other than that LGTM! |
uittenbroekrobbert
approved these changes
May 7, 2024
uittenbroekrobbert
added a commit
that referenced
this pull request
Jul 3, 2024
# This is the 1st commit message: Fix sonar badge # This is the commit message #2: Add deployment # This is the commit message #3: Add concurrency check # This is the commit message #4: Fix CI/CD deployment # This is the commit message #5: Add hash to build # This is the commit message #6: Inject version into template # This is the commit message #7: Fix typo in deployment
uittenbroekrobbert
added a commit
that referenced
this pull request
Jul 3, 2024
# This is the 1st commit message: Fix sonar badge # This is the commit message #2: Add deployment # This is the commit message #3: Add concurrency check # This is the commit message #4: Fix CI/CD deployment # This is the commit message #5: Add hash to build # This is the commit message #6: Inject version into template # This is the commit message #7: Fix typo in deployment # This is the commit message #8: Bump the allpip group across 1 directory with 5 updates Bumps the allpip group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [sqlmodel](https://github.com/tiangolo/sqlmodel) | `0.0.18` | `0.0.19` | | [pydantic](https://github.com/pydantic/pydantic) | `2.7.3` | `2.7.4` | | [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.3.1` | `2.3.3` | | [ruff](https://github.com/astral-sh/ruff) | `0.4.8` | `0.4.9` | | [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.366` | `1.1.367` | Updates `sqlmodel` from 0.0.18 to 0.0.19 - [Release notes](https://github.com/tiangolo/sqlmodel/releases) - [Changelog](https://github.com/tiangolo/sqlmodel/blob/main/docs/release-notes.md) - [Commits](fastapi/sqlmodel@0.0.18...0.0.19) Updates `pydantic` from 2.7.3 to 2.7.4 - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v2.7.3...v2.7.4) Updates `pydantic-settings` from 2.3.1 to 2.3.3 - [Release notes](https://github.com/pydantic/pydantic-settings/releases) - [Commits](pydantic/pydantic-settings@v2.3.1...v2.3.3) Updates `ruff` from 0.4.8 to 0.4.9 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.4.8...v0.4.9) Updates `pyright` from 1.1.366 to 1.1.367 - [Release notes](https://github.com/RobertCraigie/pyright-python/releases) - [Commits](RobertCraigie/pyright-python@v1.1.366...v1.1.367) --- updated-dependencies: - dependency-name: sqlmodel dependency-type: direct:production update-type: version-update:semver-patch dependency-group: allpip - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-patch dependency-group: allpip - dependency-name: pydantic-settings dependency-type: direct:production update-type: version-update:semver-patch dependency-group: allpip - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch dependency-group: allpip - dependency-name: pyright dependency-type: direct:development update-type: version-update:semver-patch dependency-group: allpip ... Signed-off-by: dependabot[bot] <[email protected]> # This is the commit message #9: Add automerge for dependabot & pre-commit and change CODEOWNERS
uittenbroekrobbert
added a commit
that referenced
this pull request
Jul 3, 2024
# This is the 1st commit message: Fix sonar badge # This is the commit message #2: Add deployment # This is the commit message #3: Add concurrency check # This is the commit message #4: Fix CI/CD deployment # This is the commit message #5: Add hash to build # This is the commit message #6: Inject version into template # This is the commit message #7: Fix typo in deployment # This is the commit message #8: Bump the allpip group across 1 directory with 5 updates Bumps the allpip group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [sqlmodel](https://github.com/tiangolo/sqlmodel) | `0.0.18` | `0.0.19` | | [pydantic](https://github.com/pydantic/pydantic) | `2.7.3` | `2.7.4` | | [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.3.1` | `2.3.3` | | [ruff](https://github.com/astral-sh/ruff) | `0.4.8` | `0.4.9` | | [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.366` | `1.1.367` | Updates `sqlmodel` from 0.0.18 to 0.0.19 - [Release notes](https://github.com/tiangolo/sqlmodel/releases) - [Changelog](https://github.com/tiangolo/sqlmodel/blob/main/docs/release-notes.md) - [Commits](fastapi/sqlmodel@0.0.18...0.0.19) Updates `pydantic` from 2.7.3 to 2.7.4 - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v2.7.3...v2.7.4) Updates `pydantic-settings` from 2.3.1 to 2.3.3 - [Release notes](https://github.com/pydantic/pydantic-settings/releases) - [Commits](pydantic/pydantic-settings@v2.3.1...v2.3.3) Updates `ruff` from 0.4.8 to 0.4.9 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.4.8...v0.4.9) Updates `pyright` from 1.1.366 to 1.1.367 - [Release notes](https://github.com/RobertCraigie/pyright-python/releases) - [Commits](RobertCraigie/pyright-python@v1.1.366...v1.1.367) --- updated-dependencies: - dependency-name: sqlmodel dependency-type: direct:production update-type: version-update:semver-patch dependency-group: allpip - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-patch dependency-group: allpip - dependency-name: pydantic-settings dependency-type: direct:production update-type: version-update:semver-patch dependency-group: allpip - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch dependency-group: allpip - dependency-name: pyright dependency-type: direct:development update-type: version-update:semver-patch dependency-group: allpip ... Signed-off-by: dependabot[bot] <[email protected]> # This is the commit message #9: Add automerge for dependabot & pre-commit and change CODEOWNERS # This is the commit message #10: Add database schema initialization # This is the commit message #11: Update .pre-commit-config.yaml updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9) # This is the commit message #12: Fix deployment order # This is the commit message #13: Fix deploy tag # This is the commit message #14: Fix deployment repo access # This is the commit message #15: Fix tag deployments # This is the commit message #16: Fix version labeling container # This is the commit message #17: Update .pre-commit-config.yaml updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup Project
This sets up the CI system and changes al needed values to correct ones from the template project.
Resolves #3
Checklist
Please check all the boxes that apply to this pull request using "x":