-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more demo objects to the demo suite #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would make the functions generic
Hm, I'm not sure what you mean or how that helps. Can you elaborate? |
91399b4
to
a6d3a98
Compare
I mean that i would take hardcodes arrays outside of the function. example:
i would rewrite to:
This would allow more flexibility in what demo mode is. |
554c1b3
to
4b2c3df
Compare
354128d
to
4c97b93
Compare
tad/migrations/versions/b62dbd9468e4_create_status_user_and_task_table.py
Outdated
Show resolved
Hide resolved
tad/migrations/versions/b62dbd9468e4_create_status_user_and_task_table.py
Outdated
Show resolved
Hide resolved
0735500
to
ba6f74c
Compare
35bfe85
to
2f16ecc
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Create a demo environment with 4 status columns, 3 example tasks and a user. The status names have been updated to be picked up by the translation module. This PR also renames the statuses created in a previous version so translation works.
Checklist
Please check all the boxes that apply to this pull request using "x":