Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed hero image #430

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fixed hero image #430

merged 1 commit into from
Dec 17, 2024
+152 −152

Conversation

rubenrouwhof
Copy link
Contributor

Description

Fix to show the hero image as intended: title, button and blue background on top of image.

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@rubenrouwhof rubenrouwhof requested a review from a team as a code owner December 17, 2024 10:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

laurensWe
laurensWe approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👯

@rubenrouwhof rubenrouwhof merged commit 934ad99 into main Dec 17, 2024
15 checks passed
@rubenrouwhof rubenrouwhof deleted the bug/hero-component branch December 17, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurensWe laurensWe laurensWe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenrouwhof @laurensWe