Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb and beslishulp fix #405

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Breadcrumb and beslishulp fix #405

merged 2 commits into from
Nov 29, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Nov 28, 2024 •
edited
Loading

Description

There is a span misplaced in the breadcrumbs which makes it looks wrong. This fixes that.

It also fixes the link for the beslishulp.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner November 28, 2024 13:42
@uittenbroekrobbert uittenbroekrobbert changed the title Minor: breadcrumb fix Minor: breadcrumb and beslishulp fix Nov 28, 2024
@uittenbroekrobbert uittenbroekrobbert changed the title Minor: breadcrumb and beslishulp fix Breadcrumb and beslishulp fix Nov 28, 2024
berrydenhartog
berrydenhartog previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anneschuth
anneschuth previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uittenbroekrobbert uittenbroekrobbert force-pushed the bugfix-breadcrumbs branch 2 times, most recently from 5fbfad1 to e69ef46 Compare November 29, 2024 07:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@uittenbroekrobbert uittenbroekrobbert merged commit b8d5163 into main Nov 29, 2024
14 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the bugfix-breadcrumbs branch November 29, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbertbos robbertbos robbertbos approved these changes

@berrydenhartog berrydenhartog berrydenhartog left review comments

@anneschuth anneschuth anneschuth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uittenbroekrobbert @anneschuth @robbertbos @berrydenhartog