Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment #37

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Add deployment #37

merged 2 commits into from
Jun 14, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Jun 11, 2024

Description

This is a prototype for a deployment. Not sure if it works until we test it

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog requested a review from a team as a code owner June 11, 2024 22:29
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/deploy.yml Show resolved Hide resolved
@berrydenhartog berrydenhartog requested a review from laurensWe June 12, 2024 07:23
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thank you!

@laurensWe laurensWe merged commit 4e0fc31 into main Jun 14, 2024
11 checks passed
@laurensWe laurensWe deleted the add-deployment branch June 14, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants