Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add organizations #362

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add organizations #362

merged 1 commit into from
Nov 28, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Nov 14, 2024 •
edited
Loading

Description

Adds organizations to AMT. This adds the main functions: add and view organizations as well all relationships with users and algorithms. Another PR will add the views to do user management and list algorithms for an organization.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Nov 14, 2024 that may be closed by this pull request
Add organisations + link people & algorithms to organisations #311
Closed
@uittenbroekrobbert uittenbroekrobbert force-pushed the 311-add-organisations branch 3 times, most recently from 110a7a4 to c4197c6 Compare November 27, 2024 08:24
berrydenhartog
berrydenhartog previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review November 27, 2024 09:44
@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner November 27, 2024 09:44
@uittenbroekrobbert uittenbroekrobbert force-pushed the 311-add-organisations branch 12 times, most recently from 05d12b9 to 9a85e16 Compare November 28, 2024 08:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
81.1% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

berrydenhartog
berrydenhartog approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert merged commit 1b0d47a into main Nov 28, 2024
13 of 14 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 311-add-organisations branch November 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add organisations + link people & algorithms to organisations
2 participants
@uittenbroekrobbert @berrydenhartog