Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename project to algorithm #359

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Rename project to algorithm #359

merged 1 commit into from
Nov 14, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Nov 13, 2024 •
edited
Loading

Description

Note: Rename of ticket 326 is done in two tickets to make reviewing easier

Resolves #326

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Nov 13, 2024 that may be closed by this pull request
Refactor the references of project everywhere and rename "algorithm system(s)" to "algorithm(s)" #326
Closed
@berrydenhartog berrydenhartog force-pushed the 326-refactor-the-references-of-project-everywhere-and-rename-algorithm-systems-to-algorithms branch 6 times, most recently from c56f29a to 5877c49 Compare November 13, 2024 14:39
@berrydenhartog berrydenhartog marked this pull request as ready for review November 13, 2024 14:41
@berrydenhartog berrydenhartog requested a review from a team as a code owner November 13, 2024 14:41
@berrydenhartog berrydenhartog changed the title Rename project to algortim system Rename project to algorithm Nov 13, 2024
@berrydenhartog berrydenhartog force-pushed the 326-refactor-the-references-of-project-everywhere-and-rename-algorithm-systems-to-algorithms branch 5 times, most recently from da84080 to a61b849 Compare November 13, 2024 15:30
@berrydenhartog berrydenhartog force-pushed the 326-refactor-the-references-of-project-everywhere-and-rename-algorithm-systems-to-algorithms branch from a61b849 to b94a773 Compare November 13, 2024 15:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud

uittenbroekrobbert
uittenbroekrobbert approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left 2 remarks / questions.

@berrydenhartog berrydenhartog merged commit 116ef9e into main Nov 14, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the 326-refactor-the-references-of-project-everywhere-and-rename-algorithm-systems-to-algorithms branch November 14, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the references of project everywhere and rename "algorithm system(s)" to "algorithm(s)"
2 participants
@berrydenhartog @uittenbroekrobbert