Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring code coverage back up and change pre-commit #350

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Bring code coverage back up and change pre-commit #350

merged 1 commit into from
Nov 8, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Nov 7, 2024 •
edited
Loading

Description

  • Added new tests for parts that where not tested due to the crunch of 18 October
  • Change the code coverage to be able to handle concurrency in the tests
  • Bring the required code coverage back to 95% minimally

Resolves #312

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner November 7, 2024 13:03
@laurensWe laurensWe linked an issue Nov 7, 2024 that may be closed by this pull request
Bring test coverage back #312
Closed
5 tasks
@laurensWe laurensWe force-pushed the 312-bring-test-coverage-back branch from 2f3f32f to 6ea39e7 Compare November 7, 2024 13:20
berrydenhartog
berrydenhartog previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert force-pushed the 312-bring-test-coverage-back branch from 6ea39e7 to 2ee0006 Compare November 8, 2024 10:48
@uittenbroekrobbert uittenbroekrobbert force-pushed the 312-bring-test-coverage-back branch from 2ee0006 to 2623554 Compare November 8, 2024 11:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uittenbroekrobbert uittenbroekrobbert merged commit c72825a into main Nov 8, 2024
14 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 312-bring-test-coverage-back branch November 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

@berrydenhartog berrydenhartog berrydenhartog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring test coverage back
3 participants
@laurensWe @berrydenhartog @uittenbroekrobbert