Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github action that clean up container packages #20

Merged
merged 4 commits into from
May 23, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented May 16, 2024

Description

We can not delete the containers in the package registry since we use container manifests. meaning untagged packages are used by manifest containers. we need a smarter github action to handle these.

Resolves #2

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog requested a review from a team as a code owner May 16, 2024 09:48
@berrydenhartog berrydenhartog force-pushed the cleanup-actions-for-containers branch from c2e7940 to b85af17 Compare May 16, 2024 09:50
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next to removing the github action you also changed the security scan of trivy right? Is this intended?

@berrydenhartog
Copy link
Member Author

Next to removing the github action you also changed the security scan of trivy right? Is this intended?

Yes. didnt want to make a new PR. But if you prefer a new PR i will make one

@berrydenhartog berrydenhartog force-pushed the cleanup-actions-for-containers branch 2 times, most recently from 9f4bb76 to 263eeea Compare May 16, 2024 13:42
@berrydenhartog berrydenhartog force-pushed the cleanup-actions-for-containers branch from 263eeea to c3e51da Compare May 16, 2024 13:46
@berrydenhartog berrydenhartog changed the title Remove github action that cleans up container packages Remove github action that clean up container packages May 20, 2024
@berrydenhartog berrydenhartog enabled auto-merge May 23, 2024 06:56
@berrydenhartog berrydenhartog merged commit fd01d3e into main May 23, 2024
10 checks passed
@berrydenhartog berrydenhartog deleted the cleanup-actions-for-containers branch May 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MVP for a page with a list of project tasks grouped per status
3 participants