Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate logging #19

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix duplicate logging #19

merged 2 commits into from
May 15, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented May 15, 2024 •
edited
Loading

Description

we get duplicate log lines and had some issues with sonarcloud coverage. this solves it

Resolves #2

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog requested a review from a team as a code owner May 15, 2024 14:16
@uittenbroekrobbert uittenbroekrobbert merged commit 0517827 into main May 15, 2024
10 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the fix-duplicate-logging branch May 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MVP for a page with a list of project tasks grouped per status
2 participants
@berrydenhartog @uittenbroekrobbert