Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonarcloud integration #16

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix sonarcloud integration #16

merged 1 commit into from
May 15, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented May 15, 2024 •
edited
Loading

Description

Sonarcloud is picking up tests/ in the code coverage which are not covered.

Resolves #2

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog marked this pull request as ready for review May 15, 2024 08:41
@berrydenhartog berrydenhartog requested a review from a team as a code owner May 15, 2024 08:41
@berrydenhartog berrydenhartog merged commit e68ea51 into main May 15, 2024
10 checks passed
@berrydenhartog berrydenhartog deleted the fix-sonarcloud branch May 15, 2024 08:41
uittenbroekrobbert added a commit that referenced this pull request Jul 3, 2024
@uittenbroekrobbert
# This is a combination of 17 commits.
6c7f52f 
# This is the 1st commit message:

Fix sonar badge

# This is the commit message #2:

Add deployment

# This is the commit message #3:

Add concurrency check

# This is the commit message #4:

Fix CI/CD deployment

# This is the commit message #5:

Add hash to build

# This is the commit message #6:

Inject version into template

# This is the commit message #7:

Fix typo in deployment

# This is the commit message #8:

Bump the allpip group across 1 directory with 5 updates

Bumps the allpip group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [sqlmodel](https://github.com/tiangolo/sqlmodel) | `0.0.18` | `0.0.19` |
| [pydantic](https://github.com/pydantic/pydantic) | `2.7.3` | `2.7.4` |
| [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.3.1` | `2.3.3` |
| [ruff](https://github.com/astral-sh/ruff) | `0.4.8` | `0.4.9` |
| [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.366` | `1.1.367` |



Updates `sqlmodel` from 0.0.18 to 0.0.19
- [Release notes](https://github.com/tiangolo/sqlmodel/releases)
- [Changelog](https://github.com/tiangolo/sqlmodel/blob/main/docs/release-notes.md)
- [Commits](fastapi/sqlmodel@0.0.18...0.0.19)

Updates `pydantic` from 2.7.3 to 2.7.4
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.3...v2.7.4)

Updates `pydantic-settings` from 2.3.1 to 2.3.3
- [Release notes](https://github.com/pydantic/pydantic-settings/releases)
- [Commits](pydantic/pydantic-settings@v2.3.1...v2.3.3)

Updates `ruff` from 0.4.8 to 0.4.9
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.4.8...v0.4.9)

Updates `pyright` from 1.1.366 to 1.1.367
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.366...v1.1.367)

---
updated-dependencies:
- dependency-name: sqlmodel
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic-settings
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pyright
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
...

Signed-off-by: dependabot[bot] <[email protected]>
# This is the commit message #9:

Add automerge for dependabot & pre-commit and change CODEOWNERS

# This is the commit message #10:

Add database schema initialization

# This is the commit message #11:

Update .pre-commit-config.yaml

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9)

# This is the commit message #12:

Fix deployment order

# This is the commit message #13:

Fix deploy tag

# This is the commit message #14:

Fix deployment repo access

# This is the commit message #15:

Fix tag deployments

# This is the commit message #16:

Fix version labeling container

# This is the commit message #17:

Update .pre-commit-config.yaml

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MVP for a page with a list of project tasks grouped per status
2 participants
@berrydenhartog @uittenbroekrobbert