Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup mvp cards #14

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Setup mvp cards #14

merged 1 commit into from
Jun 6, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented May 13, 2024

Description

Add a GUI to the project and make it possible to move tasks between different statuses.

This PR resolves https://github.com/orgs/MinBZK/projects/7?pane=issue&itemId=63118412

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to our community 🤗 and thank you for your first contribution.

As a first time contributor please make sure to review our contribution guidelines ❤️

@uittenbroekrobbert uittenbroekrobbert changed the base branch from main to setup-fastapi-htmx May 13, 2024 11:39
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a thorough review yet, but looks good!

Left a series of comments to use fastapi's template rendering.

tad/routers/tasks.py Outdated Show resolved Hide resolved
tad/routers/tasks.py Outdated Show resolved Hide resolved
tad/routers/tasks.py Outdated Show resolved Hide resolved
@uittenbroekrobbert uittenbroekrobbert added the enhancement New feature or request label May 14, 2024
Base automatically changed from setup-fastapi-htmx to main May 15, 2024 06:58
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tad/api/routes/tasks.py Outdated Show resolved Hide resolved
@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review May 28, 2024 13:06
@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner May 28, 2024 13:06
@uittenbroekrobbert uittenbroekrobbert force-pushed the setup-mvp-cards branch 2 times, most recently from fccce5c to d8f7b92 Compare May 29, 2024 13:31
@uittenbroekrobbert uittenbroekrobbert force-pushed the setup-mvp-cards branch 2 times, most recently from b211a4f to ac57364 Compare June 3, 2024 10:20
tad/core/config.py Outdated Show resolved Hide resolved
tad/models/status.py Outdated Show resolved Hide resolved
tad/models/task.py Outdated Show resolved Hide resolved
tad/models/task.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example test for jinja templates ?

Copy link

sonarqubecloud bot commented Jun 6, 2024

Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog merged commit 1a47362 into main Jun 6, 2024
11 checks passed
@berrydenhartog berrydenhartog deleted the setup-mvp-cards branch June 6, 2024 08:47
uittenbroekrobbert added a commit that referenced this pull request Jul 3, 2024
# This is the 1st commit message:

Fix sonar badge

# This is the commit message #2:

Add deployment

# This is the commit message #3:

Add concurrency check

# This is the commit message #4:

Fix CI/CD deployment

# This is the commit message #5:

Add hash to build

# This is the commit message #6:

Inject version into template

# This is the commit message #7:

Fix typo in deployment

# This is the commit message #8:

Bump the allpip group across 1 directory with 5 updates

Bumps the allpip group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [sqlmodel](https://github.com/tiangolo/sqlmodel) | `0.0.18` | `0.0.19` |
| [pydantic](https://github.com/pydantic/pydantic) | `2.7.3` | `2.7.4` |
| [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.3.1` | `2.3.3` |
| [ruff](https://github.com/astral-sh/ruff) | `0.4.8` | `0.4.9` |
| [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.366` | `1.1.367` |



Updates `sqlmodel` from 0.0.18 to 0.0.19
- [Release notes](https://github.com/tiangolo/sqlmodel/releases)
- [Changelog](https://github.com/tiangolo/sqlmodel/blob/main/docs/release-notes.md)
- [Commits](fastapi/sqlmodel@0.0.18...0.0.19)

Updates `pydantic` from 2.7.3 to 2.7.4
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.3...v2.7.4)

Updates `pydantic-settings` from 2.3.1 to 2.3.3
- [Release notes](https://github.com/pydantic/pydantic-settings/releases)
- [Commits](pydantic/pydantic-settings@v2.3.1...v2.3.3)

Updates `ruff` from 0.4.8 to 0.4.9
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.4.8...v0.4.9)

Updates `pyright` from 1.1.366 to 1.1.367
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.366...v1.1.367)

---
updated-dependencies:
- dependency-name: sqlmodel
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic-settings
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pyright
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
...

Signed-off-by: dependabot[bot] <[email protected]>
# This is the commit message #9:

Add automerge for dependabot & pre-commit and change CODEOWNERS

# This is the commit message #10:

Add database schema initialization

# This is the commit message #11:

Update .pre-commit-config.yaml

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9)

# This is the commit message #12:

Fix deployment order

# This is the commit message #13:

Fix deploy tag

# This is the commit message #14:

Fix deployment repo access

# This is the commit message #15:

Fix tag deployments

# This is the commit message #16:

Fix version labeling container

# This is the commit message #17:

Update .pre-commit-config.yaml

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants