Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package deploy location to GitHub release instead of NPM #207

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Change package deploy location to GitHub release instead of NPM #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions .github/workflows/release-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build Node.js Package and Publish to Github Packages
name: Build Node.js Package and Publish Assets

on:
release:
types: [created]

jobs:
publish-gpr:
publish:
runs-on: ubuntu-latest
permissions:
packages: write
Expand All @@ -15,16 +15,11 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: 20
registry-url: https://registry.npmjs.org/


- name: Change version number from release
run: |
sed -i 's|"version": .*$|"version": "${{ github.event.release.tag_name }}",|g' frontend/package.json

- run: npm install --prefix frontend
- run: npm run build --prefix frontend
- run: npm run prepub --prefix frontend
- run: npm publish ./frontend/dist --access=public
env:
NODE_AUTH_TOKEN: ${{secrets.NPMJS_ACCESS_TOKEN}}
- name: Publish release assets
uses: softprops/action-gh-release@v2
with:
files: |
dist/index.js
LICENSE.md
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ Om door de beslisboom te lopen is een visualizatie tool gemaakt. Met deze tool k

### Frontend locaal draaien

Om de development omgeving te standariseren maken we gebruik van [devcontainers](https://code.visualstudio.com/docs/devcontainers/containers#_getting-started).
Om de development omgeving te standaardiseren maken we gebruik van [devcontainers](https://code.visualstudio.com/docs/devcontainers/containers#_getting-started).

Als u in de devcontainer zit kunt u de volgende commandos uitvoeren. Voordat dit kan gaat u eerst in de frontend/ folder staan met een terminal.
Als u in de devcontainer zit kunt u de volgende commando's uitvoeren. Voordat dit kan gaat u eerst in de frontend/ folder staan met een terminal.

Start de tool:

Expand Down Expand Up @@ -143,7 +143,7 @@ kubectl apply -k infra/

## Validatie schema

Door het volgende script te runnen, kunt u controlen of het bestand decision-tree.yaml en het bestand definitions.yaml (technisch) valide zijn. Eventuele (syntax)fouten worden hiermee aangegeven.
Door het volgende script te runnen, kunt u controleren of het bestand decision-tree.yaml en het bestand definitions.yaml (technisch) valide zijn. Eventuele (syntax)fouten worden hiermee aangegeven.

```sh
./script/validate --file_pairs schemas/schema_decision_tree.json:decision-tree.yaml schemas/schema_definitions.json:definitions.yaml
Expand Down