Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering and complex relations #269

Merged
merged 37 commits into from
Sep 23, 2024

Conversation

rubenrouwhof
Copy link
Collaborator

Added filters and updated table. The new styling is a branch https://github.com/MinBZK/Algoritmekader/tree/implement-overheidnl-styling

Bij welk issue hoort deze pull-request?

Checklist before requesting a review

  • Ik heb de contributing guidelines van deze repository gelezen en gevolgd.
  • Ik heb mijn aanpassingen gecheckt op spelfouten.
  • Als ik gebruik heb gemaakt van links, dan heb ik gecheckt of deze werken.
  • Ik heb gebruik gemaakt van de templates en formats van het algoritmekader.

Copy link

github-actions bot commented Sep 16, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-23 12:10 UTC

@rubenrouwhof rubenrouwhof force-pushed the add-filtering-and-complex-relations branch 3 times, most recently from ba83264 to 90ab869 Compare September 16, 2024 21:52
@ruthkoole ruthkoole linked an issue Sep 20, 2024 that may be closed by this pull request
@ruthkoole
Copy link
Collaborator

Volgens mij werken de filters en de linkjes nu goed!

Eerder waren de labels in de tabel naar bijvoorbeeld een fase in de levenscyclus klikbaar, dat is nu niet meer. Wat mij betreft niet heel erg, maar zou nog wel een mooie toevoeging zijn (kan ook later)?

Copy link
Collaborator

@ruthkoole ruthkoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruthkoole ruthkoole marked this pull request as ready for review September 23, 2024 10:21
@ruthkoole ruthkoole merged commit 62ce4c4 into main Sep 23, 2024
1 check passed
@ruthkoole ruthkoole deleted the add-filtering-and-complex-relations branch September 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement filters for maatregelen & vereisten AK
2 participants