Various improvements in LZ4Net #44

gleocadie · 2020-08-04T10:18:46Z

Add support for async
Various fixes (ionic hintpath, remove net2 support...)
bump to netstandard 2.0

msbuild path is hardcoded, we need to resolve it dynamically

v141 isn't installed on our jenkins servers

Also, revert the changes on portable

MiloszKrajewski · 2020-08-09T13:19:35Z

Thank you for your fixes, I'll review them and check which ones still apply to K4os.Compression.LZ4.

Is there any particular reason you are not using the new version?

gleocadie · 2020-08-09T17:02:40Z

Hello, oh... good question. Maybe we did not see the new version.
I'll check if we can use it instead (we might have missed it)

I found that there is one commit specific to our company: Add -criteo suffix to the nuget version number

I'll check the new version and I'll ping you (maybe the async version for LZ4Stream).

thanks for your answer.

Kevin Gosse and others added 11 commits February 4, 2019 10:58

Upgrade projects

f085d1e

Implement async APIs for LZ4Stream

fa3ae8d

Fix build script

41ebbf8

msbuild path is hardcoded, we need to resolve it dynamically

Add -criteo suffix to the nuget version number

253f79e

Downgrade toolset to v140

1ab86c2

v141 isn't installed on our jenkins servers

Change PlatformToolset

36c2be4

Override VCTargetsPath in build script

b4b2b8b

Remove net2 target

464b26d

Fix Ionic hint path

e365170

Correctly include async files in netcore/portable

442ff9f

Bump to netstandard2.0

b4f1bfc

Also, revert the changes on portable

Provide feedback