Add support for authenticated iframe (with JWT) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHP is far from my preferred language, I don't use it a long time, so feel free to change the code if you see something wrong. I didn't use IDE, so I don't know if there's some code warning or deprecation. Tested with PHP 8.1, with Icinga DB. JWT is very useful, it is easy to configure on Grafana, and well documented. |
epinter
force-pushed
the
feature-iframe-jwtauth
branch
3 times, most recently
from
996e36b
to
1863828
Compare
The image renderer from Grafana is very slow and cpu heavy. Iframe is not an option for most cases because it needs anonymous access to Grafana. This commit adds JWT support to secure the Grafana access when using iframe. When a graph is loaded in Icinga web interface, the signed JWT token is sent to Grafana in the request, if JWT is validated graph is displayed, if anything goes wrong with the token validation, Grafana will refuse the access. The library Firebase PHP-JWT is used to create the token. For now, the library is included in the vendor directory. The JWT token uses RSA keys, these keys are generated automatically in /etc when the user saves the configuration with jwt enabled.
epinter
force-pushed
the
feature-iframe-jwtauth
branch
from
1863828
to
5f5cff8
Compare
|
Forgot to mention, the JWT auth support was introduced in Grafana 8.0.0-beta1 |
|
This works fine for me. Is it going to be merged? |
chrostek
reviewed
Feb 29, 2024
| 'class' => 'autosubmit', | ||
| ) | ||
| ); | ||
| if ($formData['grafana_jwtEnable']) { |
There was a problem hiding this comment.
thorws an error in my setup, better:
if (isset($formData['grafana_jwtEnable']) && $formData['grafana_jwtEnable']) {
?
except this it works perfectly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image renderer from Grafana is very slow and cpu heavy. Iframe is not an option for most cases because it needs anonymous access to Grafana. This commit adds JWT support to secure the Grafana access when using iframe.
When a graph is loaded in Icinga web interface, the signed JWT token is sent to Grafana in the request, if JWT is validated graph is displayed, if anything goes wrong with the token validation, Grafana will refuse the access.
The library Firebase PHP-JWT is used to create the token. For now, the library is included in the vendor directory.
The JWT token uses RSA keys, these keys are generated automatically in /etc when the user saves the configuration with jwt enabled.