Feature/es 688 disable bivariates #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #153 +/- ##
===========================================
+ Coverage 74.49% 74.62% +0.13%
===========================================
Files 11 11
Lines 3787 3791 +4
===========================================
+ Hits 2821 2829 +8
+ Misses 966 962 -4 ☔ View full report in Codecov by Sentry. |
pscheidler
approved these changes
Jun 10, 2024
Comment on lines
+2219
to
+2221
| # TODO: Remember what `padding` was for, and either implement or | ||
| # remove it completely. Related to plotting; see `plots`. | ||
| # TODO: Use `iterator`? It may have been removed accidentally. |
There was a problem hiding this comment.
Should these also be Jira tickets? I worry that comments are easier to lose
There was a problem hiding this comment.
Should these also be Jira tickets? I worry that comments are easier to lose
These are pretty vague, and neither are critical. I'm not sure it's worth cluttering up Jira; there are already a bunch of old GitHub 'enhancement' issues from different repos, and they sort of drown out the more critical issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the ability to disable bivariate polynomials, fixes a couple of bugs (bad
Transform.isValid()return type in some cases, improved validity check, others), plus a little code cleanup.