Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Python 3.12, include setuptools, require sphinx>=5.02 #151

Merged
merged 2 commits into from
May 30, 2024

Conversation

jaydenpersonnat
Copy link
Contributor

This PR resolves unit tests failing on Python 3.12. Changes include:

  • Including setuptools in requirements and setup.py
  • Re-adding Python 3.12 in unit-tests.yml
  • Requiring sphinx to be greater than or equal to version 5.0.2, rather than strictly equal.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.47%. Comparing base (c0f6b9a) to head (56fa620).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
- Coverage    74.47%   74.47%   -0.01%     
===========================================
  Files           11       11              
  Lines         3785     3784       -1     
===========================================
- Hits          2819     2818       -1     
  Misses         966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StokesMIDE StokesMIDE self-requested a review May 29, 2024 16:01
@jaydenpersonnat
Copy link
Contributor Author

  • Updated readthedocs.yaml to use Python 3.9.
  • Updated requirements.txt in \docs to require sphinx>=5.0.2

Copy link
Member

@StokesMIDE StokesMIDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do you think the various sphinxcontrib-* packages should have their versions unpinned as well? It doesn't matter too much either way; it can be addressed if/when there's a problem in the future.

@jaydenpersonnat jaydenpersonnat merged commit f8df14d into develop May 30, 2024
31 checks passed
@jaydenpersonnat jaydenpersonnat deleted the fix_sphinx_python12 branch May 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants