Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-295: Save Lab metadata in IDE files #149

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

StokesMIDE
Copy link
Member

This implements a mechanism for reading and writing user data in an .IDE file. Several new elements have been added to the schema for this purpose. The specific child elements of <UserData> may undergo revision.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 85.55556% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.60%. Comparing base (6420d42) to head (656de45).

Files Patch % Lines
idelib/userdata.py 84.88% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #149      +/-   ##
===========================================
+ Coverage    74.28%   74.60%   +0.32%     
===========================================
  Files           10       11       +1     
  Lines         3691     3781      +90     
===========================================
+ Hits          2742     2821      +79     
- Misses         949      960      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StokesMIDE StokesMIDE marked this pull request as ready for review April 10, 2024 18:33
Copy link

@ethandcosta ethandcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! As far as I can tell there shouldn't be streaming issues, but I could be missing things.

Copy link
Member

@pscheidler pscheidler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really glad to see those tests in. This is too deep for me to do a thorough review

@StokesMIDE StokesMIDE merged commit 93d4f7b into develop Apr 11, 2024
35 checks passed
@StokesMIDE StokesMIDE deleted the feature/ES-295_UserData branch April 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants