Add new Sensor elements (mainly) for handling relative time sources (… #147
Conversation
idelib/schemata/mide_ide.xml
Outdated
| @@ -110,6 +110,10 @@ | |||
| <StringElement name="SensorSerialNumber" id="0x5251" multiple="0" minver="2">Sensor manufacturer-supplied serial number, if any.</StringElement> | |||
| <!-- Child elements TBD... --> | |||
| </MasterElement> | |||
| <StringElement name="SourceName" id="0x5260" multiple="0" minver="4">Human-friendly source (authority, network, or other source-of-truth) name for generic/virtual sensor types, particularly 'time' sensors.</StringElement> | |||
There was a problem hiding this comment.
This should probably be a <UnicodeElement>, since it could be a user-supplied AP name. <StringElement> is only ASCII 0x20 to 0x7e.
There was a problem hiding this comment.
Will do. Do you know if this is the same as UTF-8 (EBML_TYPE_UTF8 in the FW)? I just want to quickly confirm the FW can actually write those :-)
idelib/schemata/mide_ide.xml
Outdated
| <UIntegerElement name="DocTypeVersion" id="0x4287" multiple="0" mandatory="1" default="3" minver="1">The version of DocType interpreter used to create the file.</UIntegerElement> | ||
| <UIntegerElement name="DocTypeReadVersion" id="0x4285" multiple="0" mandatory="1" default="3" minver="1">The minimum DocType version an interpreter has to support to read this file.</UIntegerElement> | ||
| <UIntegerElement name="DocTypeVersion" id="0x4287" multiple="0" mandatory="1" default="4" minver="1">The version of DocType interpreter used to create the file.</UIntegerElement> | ||
| <UIntegerElement name="DocTypeReadVersion" id="0x4285" multiple="0" mandatory="1" default="4" minver="1">The minimum DocType version an interpreter has to support to read this file.</UIntegerElement> |
There was a problem hiding this comment.
I think <DocTypeReadVersion> should only get bumped when we break compatibility. We're just adding data, which our current software will happily ignore, so I say leave it as is.
Someone (almost definitely me) needs to record the official policy for incrementing <DocTypeVersion> and <DocTypeReadVersion>.
…(UTF-8) for SourceName.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #147 +/- ##
===========================================
- Coverage 74.28% 74.27% -0.02%
===========================================
Files 10 10
Lines 3691 3689 -2
===========================================
- Hits 2742 2740 -2
Misses 949 949 ☔ View full report in Codecov by Sentry. |
…https://midetech.atlassian.net/wiki/spaces/EC/pages/2251063357/Time+Sensors+Dedicated+time+source+channels+for+Authoritative+Sources), update DocTypeVersion.