Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gha tests dependency caching #102

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #102 (3453309) into develop (e0e7844) will increase coverage by 5.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #102      +/-   ##
===========================================
+ Coverage    69.05%   74.21%   +5.15%     
===========================================
  Files           10       10              
  Lines         3639     3641       +2     
===========================================
+ Hits          2513     2702     +189     
+ Misses        1126      939     -187     
Impacted Files Coverage Δ
idelib/matfile.py 71.27% <0.00%> (+50.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7844...3453309. Read the comment docs.

@CrepeGoat CrepeGoat marked this pull request as draft October 25, 2021 21:09
@CrepeGoat
Copy link
Contributor Author

CrepeGoat commented Oct 25, 2021

most recent tests show that dependencies are being pulled from the cache (see e.g., here) -> appears to be working now

@CrepeGoat CrepeGoat marked this pull request as ready for review October 25, 2021 21:14
Copy link
Contributor

@CFlaniganMide CFlaniganMide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I appreciate the changes, I think that caching dependencies on private repos adds unnecessary moving parts.

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
@CFlaniganMide
Copy link
Contributor

It looks like the hash isn't being calculated correctly, the action is reporting the key as:

Cache restored successfully
Cache restored from key: Linux-pip-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants