-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gha tests dependency caching #102
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #102 +/- ##
===========================================
+ Coverage 69.05% 74.21% +5.15%
===========================================
Files 10 10
Lines 3639 3641 +2
===========================================
+ Hits 2513 2702 +189
+ Misses 1126 939 -187
Continue to review full report at Codecov.
|
most recent tests show that dependencies are being pulled from the cache (see e.g., here) -> appears to be working now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I appreciate the changes, I think that caching dependencies on private repos adds unnecessary moving parts.
It looks like the hash isn't being calculated correctly, the action is reporting the key as:
|
Co-authored-by: Connor Flanigan <[email protected]>
- cache needs "setup.py" to generate hash value
# Conflicts: # .github/workflows/unit-tests.yml
references: