Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stack deprecation warning #225

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Conversation

jaydenpersonnat
Copy link
Contributor

@jaydenpersonnat jaydenpersonnat commented Jun 14, 2024

Small fix to resolve deprecation warning pandas.Dataframe.stack. Pandas has a new implementation of stack, which is set using future_stack=True. future_stack does not exist as a parameter in the pandas version compatible with 3.9, so Python version is checked when stack() is being used.

There's several warnings coming from numpy for python>3.9, but those seem to be internal issues with the current version of the library using deprecated pandas methods, so are probably benign.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (89e5674) to head (08c620a).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #225      +/-   ##
===============================================
+ Coverage        70.96%   70.98%   +0.02%     
===============================================
  Files               35       35              
  Lines             3220     3223       +3     
===============================================
+ Hits              2285     2288       +3     
  Misses             935      935              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

endaq/batch/core.py Outdated Show resolved Hide resolved
jaydenpersonnat and others added 3 commits June 14, 2024 10:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: David Randall Stokes <[email protected]>
@jaydenpersonnat jaydenpersonnat merged commit 42ee034 into development Jun 14, 2024
18 checks passed
@jaydenpersonnat jaydenpersonnat deleted the fix/deprecation-warnings branch June 14, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants