Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules.{moduleId}.status is required #15484

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Conversation

gimmi
Copy link
Contributor

@gimmi gimmi commented Sep 24, 2018

According to this: Azure/iot-edge-v1#613 (comment)

@PRMerger17
Copy link
Contributor

@gimmi : Thanks for your contribution! The author, @kgremban, has been notified to review your proposed change.

@kgremban
Copy link
Member

@gimmi Thank you for submitting this contribution. I don't think the new table addition is accurate, though. Only the runtime modules (agent and hub) must be started up in the "running" state. Other modules can be started in either the "running" or "stopped" state. Please list both options, and then I can approve your pull request.

@gimmi
Copy link
Contributor Author

gimmi commented Sep 29, 2018

Thanks @kgremban for evaluating the PR, I've only verified that the field is in fact required, but didn't check what the possible values are.

Will update the PR in the next few days

@gimmi
Copy link
Contributor Author

gimmi commented Oct 1, 2018

Doc updated

@kgremban
Copy link
Member

kgremban commented Oct 1, 2018

Thanks for making that change, @gimmi

#sign-off

@v-shils v-shils merged commit d7ff64c into MicrosoftDocs:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants