Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding explicitly requirement to set context of subscription #95

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

GomanovNA
Copy link
Contributor

If we can update this document explicitly defining that subscription for each context should be set in a certain way then it might help in future to have less problems. Had a ticket with Support team and even they couldn't tell me immediately what's the problem. And the problem was that I set context as az cli way and was registering feature via azure powershell and there was no error or hint to tell me that I'm enabling feature for wrong subscription. Ticket is RE: Cant create vm encryption at host - TrackingID#2411200050000262

If we can update this document explicitly defining that subscription for each context should be set in a certain way then it might help in future to have less problems. Had a ticket with Support team and even they couldn't tell me immediately what's the problem. And the problem was that I set context as az cli way and was registering feature via azure powershell and there was no error or hint to tell me that I'm enabling feature for wrong subscription. Ticket is RE: Cant create vm encryption at host - TrackingID#2411200050000262
Copy link
Contributor

@GomanovNA : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit 47b7475:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/disks-enable-host-based-encryption-portal.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 21, 2024

@roygara
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Nov 21, 2024
Copy link
Contributor

@roygara roygara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GomanovNA Thanks for helping to improve our docs, we appreciate it! Overall this looks good, just two changes then it's good to go. :)

Copy link

Learn Build status updates of commit 7cd47b7:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/disks-enable-host-based-encryption-portal.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Nov 22, 2024

@roygara, For convenience, I committed your suggestions and merged this PR based on your approval. If this article requires further changes, please open a separate pull request. Thanks!

@Court72 Court72 merged commit f93554a into MicrosoftDocs:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants