Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disks-convert-types.md #82

Closed
wants to merge 1 commit into from

Conversation

elieliteli
Copy link
Contributor

10/30 GA edits

Copy link
Contributor

@elieliteli : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit 53d60a7:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/virtual-machines/disks-convert-types.md ⚠️Warning Details
articles/virtual-machines/includes/managed-disk-premium-ssd-v2-conversion-preview.md ⚠️Warning Details

articles/virtual-machines/disks-convert-types.md

  • Line 16, Column 654: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#convert-premium-ssd-v2-disks-preview' in 'articles/virtual-machines/disks-convert-types.md'.

articles/virtual-machines/includes/managed-disk-premium-ssd-v2-conversion-preview.md

  • Line 12, Column 169: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#convert-premium-ssd-v2-disks-preview' in 'articles/virtual-machines/includes/managed-disk-premium-ssd-v2-conversion-preview.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 29, 2024

@roygara -
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

NOTE - all validation issues must be resolved before we can merge. changing the H2 has broken some links. @elieliteli - can you update the relevant files/lines to fix that? thanks.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Oct 29, 2024
@@ -98,7 +97,7 @@ $rgName = 'yourResourceGroup'
# Name of the your virtual machine
$vmName = 'yourVM'

# Choose between Standard_LRS, StandardSSD_LRS, StandardSSD_ZRS, Premium_ZRS, and Premium_LRS based on your scenario
# Choose between Standard_LRS, StandardSSD_LRS, StandardSSD_ZRS, Premium_ZRS, Premium_LRS, and PemiumV2_LRS based on your scenario
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, there is a typo in PemiumV2_LRS

@roygara
Copy link
Contributor

roygara commented Nov 4, 2024

These changes were merged separately.

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants