This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Timestamp added to score on top-n scenario #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look at my comments under issue #615 . The code changes look all good and are ready to be merge, but I'd love an implemented scenario where we actually use the suggested change, before we continue with the merge. Can I help with that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #615
Sorry, not done this don't know how??
Description:
Added a Timestamp to the Score in top-n and around-me scenario's. Automatically set in Score function to UtcNow and returned in output in Leaderboard functions.
Test:
Add a score and get the leaderboard. See the timestamp in the output.