Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved validation handling for Array of validation functions. #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ainesophaur
Copy link

By inherently assuming the validation value is true, failed validations would then be overridden by successful validations (or vise-versa)

The proposed validation handler for an Array of validationFn assumes the validity is undefined until it fails. If it reaches the end of the validationFns, then the result can be assumed to be true.

The following return types will trigger validation to be false

  • Error returned
  • false returned
  • string returned

There is also an additional propType for validationQuickBail which will short circuit validation if set and an previous error has been discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant