Introduce SVG rasterizer logic #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 483 files ±0 483 suites ±0 10m 51s ⏱️ + 2m 1s For more details on these failures and errors, see this check. Results for commit e40e2a8. ± Comparison against base commit 2ce8542. ♻️ This comment has been updated with latest results. |
Michael5601
force-pushed
the
IconScalingBackup
branch
10 times, most recently
from
1ab97f4 to
1efaf36
Compare
HeikoKlare
reviewed
Dec 5, 2024
bundles/org.eclipse.swt.svg/src/org/eclipse/swt/svg/SVGRasterizer.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt.svg/src/org/eclipse/swt/svg/SVGRasterizer.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt.svg/src/org/eclipse/swt/svg/SVGRasterizer.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt.svg/src/org/eclipse/swt/svg/SVGRasterizer.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/ISVGRasterizer.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/ImageLoader.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/ImageLoader.java
Outdated
Show resolved
Hide resolved
Michael5601
force-pushed
the
IconScalingBackup
branch
7 times, most recently
from
10b80f3 to
3612a63
Compare
Feature Proposal: Rasterization of SVGs at Runtime for Eclipse Icons Fixes eclipse-platform#1438 Eclipse currently loads icons exclusively as raster graphics (e.g., `.png`), without support for vector formats like `.svg`. A major drawback of raster graphics is their inability to scale without degrading image quality. Additionally, generating icons of different sizes requires manually rasterizing SVGs outside Eclipse, leading to unnecessary effort and many icon files. This PR introduces support for vector graphics in Eclipse, enabling SVGs to be used for icons. Existing PNG icons will continue to be loaded alongside SVGs, allowing the use of the new functionality without the need to replace all PNG files at once. --- - **How It Works**: - To use SVG icons, simply place the SVG file in the bundle and reference it in the `plugin.xml` and other necessary locations, as is done for PNGs. No additional configuration is required. - At runtime, Eclipse uses the library JSVG to rasterize the SVG into a raster image of the desired size, eliminating the need for scaling. My analysis shows that JSVG is the most suitable Java library for this purpose. - You need to write the flag `-Dswt.autoScale=quarter` into your `eclipse.ini` file or into the run arguments of a new configuration.
Michael5601
force-pushed
the
IconScalingBackup
branch
from
3612a63 to
e40e2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.