Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection check and re-enabled i386 and armv6l support #1

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jul 5, 2020

  • Re-enabled i386 and armv6l support by searching the latest major version that was compiled for those architecture: v11.x for armv6l and v9.x for i386
  • Use curl "-f" option to prevent it from storing 40x error pages in variable but exiting with error code instead: https://linux.die.net/man/1/curl
  • Force HTTPS connection to nodejs.org
  • Coding consistency:
    • Redirect all error messages to STDERR
    • Use single quotes around arguments with no variable calls, else double quotes
    • Use double braces for all bash conditionals
    • Do not assign a variable to another via echo + command substitution overhead
    • Use consistent if-then-else format

Fixes taaem#9

+ Re-enabled i386 and armv6l support by searching the latest major version that was compiled for those architecture: v11.x for armv6l and v9.x for i386
+ Use curl "-f" option to prevent it from storing 40x error pages in variable but exiting with error code instead: https://linux.die.net/man/1/curl
+ Force HTTPS connection to nodejs.org
+ Coding consistency: Redirect all error messages to STDOUT; Use single quotes around arguments with no variable calls, else double quotes; Use double braces for all bash conditionals; Do not assign a variable to another via echo + command substitution overhead; Use consistent if-then-else format

Signed-off-by: MichaIng <[email protected]>
@MichaIng MichaIng added the bug Something isn't working label Jul 5, 2020
@MichaIng MichaIng merged commit f67818e into master Jul 5, 2020
MichaIng pushed a commit that referenced this pull request May 6, 2021
Add support for unofficials releases from nodejs.org
@MichaIng MichaIng deleted the patch-1 branch March 30, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new version of Node does not include a binary for arm6l
1 participant