Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated parameters from smb.conf #7282

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

chelobarik
Copy link

The dietpi-software script generates a samba configuration file smb.conf with outdated parameters. The testparm verification script displays the following warnings:

# testparm
Load smb config files from /etc/samba/smb.conf
lpcfg_do_global_parameter: WARNING: The "syslog only" option is deprecated
lpcfg_do_global_parameter: WARNING: The "syslog" option is deprecated
lpcfg_do_global_parameter: WARNING: The "encrypt passwords" option is deprecated

This fix removes deprecated parameters and replaces them with current ones.

.conf/dps_96/conf Outdated Show resolved Hide resolved
@MichaIng
Copy link
Owner

Thanks, makes sense. But this disables file logging, when not appending file as well. I would actually vote for that, but then we should further increase the syslog log level. "2" implies authentication failures, AFAIK, so that probably makes sense, too.

Copy link
Owner

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let's merge this. I'll run some test whether the log level should be increase to 2, but generally we want to minimise logs to /var/log anyway (for default setup).

@MichaIng MichaIng merged commit fb955ef into MichaIng:dev Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants