Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YDNS not working by default #7262

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Fix YDNS not working by default #7262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce76b23
Beta v9.8.0 (#7235)
MichaIng Oct 17, 2024
faa3ef5
v9.8 (#7247)
MichaIng Oct 17, 2024
5f69eeb
Release v9.8 (#7246)
MichaIng Oct 17, 2024
b955b4b
Update dietpi-ddns
NatureHog Oct 29, 2024
80c4eee
Merge branch 'dev' into patch-1
NatureHog Oct 29, 2024
cd69ec9
Merge branch 'dev' into patch-1
NatureHog Oct 30, 2024
10e351a
v9.9
MichaIng Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Enhancements:

Bug fixes:
- NanoPi M1 Plus | Resolved an issue where Ethernet did not work because of a faulty kernel patch. Many thanks to @InnovoMagicCube and @InnovoDeveloper for reporting this issue: https://github.com/MichaIng/DietPi/issues/6974
- DietPi-DDNS | Resolved an issue where the YDNS update test failed due to a changed response from the server API. Many thanks to @NatureHog for reporting and solving the issue: https://github.com/MichaIng/DietPi/pull/7262

As always, many smaller code performance and stability improvements, visual and spelling fixes have been done, too much to list all of them here. Check out all code changes of this release on GitHub: https://github.com/MichaIng/DietPi/pull/ADDME

Expand Down
6 changes: 3 additions & 3 deletions dietpi/dietpi-ddns
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,15 +223,15 @@ Apply()
# shellcheck disable=SC2086
if ! result=$(curl $ipfamily -sSfL ${http_auth:+ -u "$USERNAME:$PASSWORD"} "$url" 2>&1) ||
[[ $PROVIDER == 'DuckDNS' && $result == 'KO' ]] ||
[[ $PROVIDER == 'YDNS' && $result != 'ok' ]] ||
[[ $PROVIDER == 'YDNS' && $result != 'good'* && $result != 'nochg'* ]] ||
[[ $PROVIDER == 'Dynu' && $result != 'good'* && $result != 'nochg'* ]]
then
G_DIETPI-NOTIFY 1 "DDNS update test failed, please check your input${result:+:\n$result}"
STATUS="DDNS update test failed, please check your input${result:+:\n$result}"
G_DIETPI-NOTIFY 1 "$STATUS"
return 1
else
G_DIETPI-NOTIFY 2 "DDNS update test succeeded${result:+:\n$result}"
STATUS="DDNS update test succeeded${result:+:\n$result}"
G_DIETPI-NOTIFY 2 "$STATUS"
fi

# Check and in case remove obsolete No-IP client
Expand Down