-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calico fixes #7184
calico fixes #7184
Conversation
What else should I do to get this merged? |
Sorry for the long time it took to review it. I added some comments above. Most seems fine. I guess you explicitly disabled some features, which are implicitly enabled with their parent configs? IMO this is not needed. If we enable a parent feature, it is IMO fine to have the kernel enable additional sub features of it, according to its defaults. It might be confusing, if we tailor it too much, a way that users see a kernel module or feature, but not fully functional the way they are used to on plain Debian or other distros. |
Basically everything came from getting It was a while ago and I don't remember what magic I used to get the config delta. I think it was menuconfig and the built-in config diff. (Looks like it was 6.10.11.) |
Let me undo the questioning parts, and try with that kernel. If it really does not work, we can check again. But I cannot imagine that it requires features, which are not even available in the official Debian kernel, and that it requires some otherwise enabled features to be explicitly disabled. Not sure how this config check tool works, but before we are doing weird stuff, we should at least fully understand why/what for it thinks it requires this. |
- Quartz64 | Remove features which are not available on Debian and RPi kernel either, and do not disable features explicitly, which are not disabled in Debian or RPi kernel explicitly as well. For sub features, we better follow Linux defaults, and how it is on other distros and images, to not cause confusion with a disabled sub feature, which is commonly enabled and expected. And we do not want to have an overly extended kernel. If a feature is not even enabled in the rich default Debian and/or RPi kernel, then it should be better understood, what for it is really needed.
The commit history is transparent here, so we can recover any of this, if needed. But let's go with this for now, basically matching the well known and much used Debian and RPi kernel builds. I'll create an image from this ASAP. |
@disconn3ct can you test with this kernel build: https://dietpi.com/downloads/binaries/testing/ |
Crashloop.
And
|
But the features listed as "missing" are all also listed as "optional", and do not seem at all related to listing routing rules. Can you point me to the source code of this Found it: https://github.com/projectcalico/calico/blob/master/felix/routerule/route_rule.go#L244 EDIT: root@SOQuartz:~# ip rule
RTNETLINK answers: Operation not supported
Dump terminated Yeah, that is an issue. I think I found them:
needed for any further routing capabilities, also when providing a hotspot or AP etc. Somewhat essential, also enabled in Debian and RPi kernel. I'll rebuild the kernel with these. |
So that works now: root@SOQuartz:~# ip rule
0: from all lookup local
32766: from all lookup main
32767: from all lookup default @disconn3ct can you test again the new kernel build (same directory)? I did not rebuild images, but can do so, if it makes things easier for you. |
Right, optional because some configurations need them and some don't. Calico needs them.
The new build is working. 👍 I haven't fully exercised it but it seems pretty functional so far. Calico is happy. |
Obviously it is optional for Calico as well, as the new kernel works. Network device throttling, real-time/low-latency task scheduling and IPsec is obviously not by in our case. Interesting that it did not check those essential routing table features, but I am glad we found it. |
I meant to get back to this earlier, but just fyi dietpi on an rpi4 has BLK_DEV_THROTTLING on. (The only other difference is that hugeTLB is off on the rpi and on for soquartz64.) |
Add more missing configs for Calico. With this config it joins the mesh successfully and seems to be working normally.