Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Software | Kavita: An open-source comics/mangas/ebooks with a built-in web reader #6610

Merged
merged 8 commits into from
Sep 21, 2023
Merged

DietPi-Software | Kavita: An open-source comics/mangas/ebooks with a built-in web reader #6610

merged 8 commits into from
Sep 21, 2023

Conversation

drahen
Copy link
Contributor

@drahen drahen commented Sep 11, 2023

Kavita is a fast, feature rich, cross platform reading server. Built with a focus for being a full solution for all your reading needs.

  • Serve up Manga/Webtoons/Comics (cbr, cbz, zip/rar/rar5, 7zip, raw images) and Books (epub, pdf)
  • First class responsive readers that work great on any device (phone, tablet, desktop)
  • Dark mode and customizable theming support
  • Rich Metadata support with filtering and searching
  • Ways to group reading material: Collections, Reading Lists (CBL Import), Want to Read
  • Ability to manage users with rich Role-based management for age restrictions, abilities within the app, etc
  • Rich web readers supporting webtoon, continuous reading mode (continue without leaving the reader), virtual pages (epub), etc
  • Full Localization Support

@MichaIng
Copy link
Owner

MichaIng commented Sep 11, 2023 •
edited
Loading

Many thanks. Finally an ebook server which is not programmed in Java (C# instead). Looks all simple and good.

Default port should be changed to one that is not used by other software options, but otherwise it looks all good and consistent. Will run some tests later. For now quick install tests via CI: https://github.com/MichaIng/DietPi/actions/runs/6148489933

@MichaIng MichaIng added this to the v8.22 milestone Sep 11, 2023
@MichaIng MichaIng self-requested a review September 11, 2023 15:24
@drahen
Copy link
Contributor Author

drahen commented Sep 11, 2023

Hello, thank you for the reply! I have few questions:

  1. Yes, it seems that port 5000 is common enough. How to find out which port that is not used by other software options? Or maybe could you suggest one? Or should I just put some random number that is less than 65535?
  2. It seems that one of the CI tests is failing, especially for riscv64, what should I do to fix this? Because I disable the software selection for RISC-V arch.

Thank you!

@Joulinar
Copy link
Collaborator

You can have a look to our online docs and use the search filed to simplify check for a port available.

@MichaIng
Copy link
Owner

The test script contains a complete list: https://github.com/MichaIng/DietPi/blob/master/.github/workflows/dietpi-software.bash

Now that Firefox Sync Server has been removed, port 5002 is free.

The RISC-V test is currently expected to fail. They will work again once this change in systemd has been released and Debian Sid packages updated accordingly: systemd/systemd#28954

MichaIng
MichaIng reviewed Sep 11, 2023
View reviewed changes
dietpi/dietpi-software Outdated Show resolved Hide resolved
MichaIng
MichaIng reviewed Sep 11, 2023
View reviewed changes
dietpi/dietpi-software Outdated Show resolved Hide resolved
MichaIng
MichaIng reviewed Sep 11, 2023
View reviewed changes
dietpi/dietpi-software Outdated Show resolved Hide resolved
MichaIng
MichaIng reviewed Sep 11, 2023
View reviewed changes
dietpi/dietpi-software Outdated Show resolved Hide resolved
@dirkhh dirkhh mentioned this pull request Sep 12, 2023
Open
MichaIng
MichaIng reviewed Sep 19, 2023
View reviewed changes
dietpi/dietpi-software Outdated Show resolved Hide resolved
@MichaIng
Copy link
Owner

The service also needs to be added to dietpi-services: https://github.com/drahen/DietPi/blob/master/dietpi/dietpi-services#L174

MichaIng and others added 4 commits September 19, 2023 23:59
@MichaIng
v8.21
5330cc9 
- DietPi-Patches | Hotfix possible Orange Pi 5 update issue
@drahen @MichaIng
Add Kavita
aadc96e
@drahen @MichaIng
Remove trailing spaces
4b0c7db
@drahen @MichaIng
Apply suggestions from code review
ab6f2cc 
Co-authored-by: MichaIng <[email protected]>
@MichaIng MichaIng force-pushed the master branch 2 times, most recently from 3ec26df to 54cd71e Compare September 20, 2023 23:07
@MichaIng
Copy link
Owner

MichaIng commented Sep 20, 2023 •
edited
Loading

To get this into upcoming release, I did the suggested changes and added the meta commits. Please check my last commit 🙂. Test installs are running: https://github.com/MichaIng/DietPi/actions/runs/6255056369

ToDo:

  • Test on ARMv6, as AFAIK, .NET core is generally not ARMv6-compatible. In case, disable for this architecture.

@MichaIng MichaIng force-pushed the master branch 3 times, most recently from f8ebf24 to 035d958 Compare September 20, 2023 23:40
@MichaIng
v8.22
25bb2e3 
- DietPi-Software | Kavita: Add .NET dependencies
- DietPi-Software | Kavita: Change default port to 2036 to avoid conflict with Shairport Sync
- DietPi-Software | Kavita: On reinstals, preserve config dir bug replace everything else cleanly
- DietPi-Software | Kavita: Use /opt/kavita (lower-case) as install and config/run user home dir
- DietPi-Software | Kavita: Add to dietpi-services and dietpi-survey_report, as well as README credits and changelog entry
@MichaIng
Copy link
Owner

MichaIng commented Sep 21, 2023 •
edited
Loading

Indeed no ARMv6 support:

Sep 21 19:52:04 Zero systemd[1]: Started kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Main process exited, code=killed, status=11/SEGV
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Failed with result 'signal'.
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Scheduled restart job, restart counter is at 1.
Sep 21 19:52:04 Zero systemd[1]: Stopped kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: Started kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Main process exited, code=killed, status=11/SEGV
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Failed with result 'signal'.
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Scheduled restart job, restart counter is at 2.
Sep 21 19:52:04 Zero systemd[1]: Stopped kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: Started kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Main process exited, code=killed, status=11/SEGV
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Failed with result 'signal'.
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Scheduled restart job, restart counter is at 3.
Sep 21 19:52:04 Zero systemd[1]: Stopped kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: Started kavita.service - Kavita Server (DietPi).
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Main process exited, code=killed, status=11/SEGV
Sep 21 19:52:04 Zero systemd[1]: kavita.service: Failed with result 'signal'.
Sep 21 19:52:05 Zero systemd[1]: kavita.service: Scheduled restart job, restart counter is at 4.
Sep 21 19:52:05 Zero systemd[1]: Stopped kavita.service - Kavita Server (DietPi).
Sep 21 19:52:05 Zero systemd[1]: Started kavita.service - Kavita Server (DietPi).
Sep 21 19:52:05 Zero systemd[1]: kavita.service: Main process exited, code=killed, status=11/SEGV
Sep 21 19:52:05 Zero systemd[1]: kavita.service: Failed with result 'signal'.
Sep 21 19:52:05 Zero systemd[1]: kavita.service: Scheduled restart job, restart counter is at 5.
Sep 21 19:52:05 Zero systemd[1]: Stopped kavita.service - Kavita Server (DietPi).
Sep 21 19:52:05 Zero systemd[1]: kavita.service: Start request repeated too quickly.
Sep 21 19:52:05 Zero systemd[1]: kavita.service: Failed with result 'signal'.
Sep 21 19:52:05 Zero systemd[1]: Failed to start kavita.service - Kavita Server (DietPi).

Here you can see why I am fans of either no automatic restart on error or at least a limit 🙂. But otherwise the install, reinstall and uninstall works well 👍.

@MichaIng
v8.22
fa4af0f 
- DietPi-Software | Kavita: Disable for ARMv6 as ARM binaries are ARMv7+ only, expected with .NET core
@MichaIng
Copy link
Owner

I'm merging this now. We can do any fine tuning or preferred changes from our end until Saturday (DietPi v8.22 release).

@MichaIng MichaIng merged commit cd8acf9 into MichaIng:dev Sep 21, 2023
1 check passed
@StephanStS StephanStS mentioned this pull request Sep 21, 2023
Closed
This was referenced Sep 21, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

Assignees

@drahen drahen

Labels
Software request 💿
Projects
None yet
Milestone
v8.22
Development

Successfully merging this pull request may close these issues.
3 participants
@drahen @MichaIng @Joulinar