Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the command to change the Adguard Home password #975

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix the command to change the Adguard Home password #975

merged 1 commit into from
Feb 11, 2024

Conversation

TheFrenchGhosty
Copy link
Contributor

This PR fixes the command used to change the Adguard Home password.

It used to add 2 spaces before the line started which make it invalid, this PR just make it use 4 spaces.

@MichaIng MichaIng changed the base branch from master to dev February 11, 2024 16:18
@MichaIng
Copy link
Owner

You are right. The config we use uses 2 spaces: https://github.com/MichaIng/DietPi/blob/master/.conf/dps_126/AdGuardHome.yaml
But the syntax is rewritten to indent list elements with 2 more spaces, so that directory entries of a list are indented by 4 spaces.

Hmm, we should adjust the syntax our config as well, but need to do this shortly before release, otherwise we break AdGuard Home installs, as dietpi-software downloads this file and then adds the password key with 2 spaces only 🤔.

@MichaIng MichaIng added the correction Content, spelling or syntax corrections label Feb 11, 2024
@MichaIng MichaIng merged commit c600b95 into MichaIng:dev Feb 11, 2024
1 of 2 checks passed
@TheFrenchGhosty
Copy link
Contributor Author

TheFrenchGhosty commented Feb 11, 2024

@MichaIng

You are right. The config we use uses 2 spaces: https://github.com/MichaIng/DietPi/blob/master/.conf/dps_126/AdGuardHome.yaml

My config uses 4 spaces:

users:
  - name: admin
    password: <REDACTED>

Is that what you mean with " But the syntax is rewritten to indent list elements with 2 more spaces, so that directory entries of a list are indented by 4 spaces."

@MichaIng
Copy link
Owner

Yes, obviosuly, AdGuard Home parses the config file then write it back, recreating it from scratch.

@TheFrenchGhosty TheFrenchGhosty deleted the patch-1 branch April 30, 2024 14:26
@TheFrenchGhosty TheFrenchGhosty restored the patch-1 branch April 30, 2024 14:26
@TheFrenchGhosty TheFrenchGhosty deleted the patch-1 branch April 30, 2024 14:26
@TheFrenchGhosty TheFrenchGhosty restored the patch-1 branch April 30, 2024 14:26
@TheFrenchGhosty TheFrenchGhosty deleted the patch-1 branch April 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Content, spelling or syntax corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants