Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: Downgrade Java to Java 8 #722

Merged
merged 1 commit into from
Jan 10, 2025
Merged

build!: Downgrade Java to Java 8 #722

merged 1 commit into from
Jan 10, 2025

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 10, 2025

Summary

fixes #697
It was fixed in #710, but that PR went to master and we've been on main brunch for some while, hence this PR.

Testing steps

None. I've tested kiosk. The success path is working.

Follow-up issues

Release new kiosk_mode version.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team as a code owner January 10, 2025 11:27
@witwash witwash requested a review from chaeMil January 10, 2025 11:28
@witwash witwash enabled auto-merge (squash) January 10, 2025 11:37
Copy link
Contributor

@chaeMil chaeMil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witwash witwash merged commit 61dba6e into main Jan 10, 2025
7 checks passed
@witwash witwash deleted the downgrade-java branch January 10, 2025 11:37
@KonstantenKomkov
Copy link

Can you tell me when to expect the release of the new version?

@witwash
Copy link
Contributor Author

witwash commented Jan 13, 2025

@KonstantenKomkov, let me ping the reviewer. It'll be up in an hour or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build error: Unknown Kotlin JVM target: 21
3 participants