feat!: [DX-3563] Upgrade to DCM 1.25.0 #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do prefer-immutable-bloc-state and prefer-immutable-bloc-events work correctly with freezed classes (i.e. does it recognize them as immutable)? |
|
@ookami-kb, |
|
@witwash I would rather disable these rules then. We always use freezed for both state and events anyway, so this seems like an extra work. |
|
@ookami-kb, done |
ookami-kb
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to DCM
1.25.0Enabled rules:
Common:
avoid-unnecessary-patterns
Flutter:
prefer-container
Bloc:
emit-new-bloc-state-instances
avoid-bloc-public-fields
prefer-bloc-state-suffix
prefer-bloc-event-suffix
avoid-instantiating-in-bloc-value-provider
avoid-existing-instances-in-bloc-provider
Rules left disabled:
avoid-single-field-destructuring and
prefer-assigning-await-expressions - there are a lot of cases where it is used in
tech-mo. I am not sure it is worth refactoringrecord-fields-ordering - I don't think it is needed
avoid-returning-value-from-cubit-methods - we have
avoid-cubitsand don't use them, so this one is not needed as wellprefer-immutable-bloc-state - doesn't support
freezedprefer-immutable-bloc-events - doesn't support
freezedTesting steps
Info about test cases. If you think the issue is not testable, describe why.
Follow-up issues
Is there some action/cleanup needed after this PR is merged or deployed (e.g. consolidate some part outside the scope of this PR, etc)? Create issues for it with deadline and note them here and in the PR comments.
Check during review